-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pybind11: init at 2.2.4 #54888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should be pythonPackages.pybind11: init at 2.2.4
.
Can you please explain what the difference to the package added in #35027 is and why we don't need cmake for building this one? |
0886188
to
66a3cf6
Compare
Thank you for the feedback. I update the package accordingly. Pybind11 is a header only library, that is distributed to be either used with CMake (or any other C++ build system) or within Python (with setuptool, distutil, pip, etc). See #53497 for a python example. |
Thanks. Please motivate the need for having a second expression in the Nix expression. |
To quote @yuriaisaka in #35027 (comment):
That is why there is a CMake based expression. This expression is direct at the first use case. For example pyopencl uses pybind11 this way. |
Any progress on this ? |
Please add an appropriate |
66a3cf6
to
57a9594
Compare
@dotlambda Updated check phase accordingly. |
Motivation for this change
Add the pypi version of pybind11 to address #53497.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)