Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: When generating /etc/fstab, ZFS and NFS filesystems shouldn't be checked #5499

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Dec 29, 2014

This cleans up systemd-fstab-generator warnings such as Checking was requested for "192.168.1.10:/mntpoint", but it is not a device.

@wmertens
Copy link
Contributor

wmertens commented Jan 1, 2015

This is ok, but the expression is starting to get unwieldy. Would you mind moving it to a let checkPhase=... and maybe others too? Perhaps using a list of filesystems to skip?

@wizeman
Copy link
Member Author

wizeman commented Jan 11, 2015

Sure. How does it look now?
I don't mind tweaking it more if you'd like.

@wmertens
Copy link
Contributor

sorry for the delay, and I come back requesting more tweaks 😁 :

  • move the common case of fs.noCheck to the front
  • move fsType "none" into the filesystems to skip
  • remove the unneeded parenthesis around (skipCheck fs)

looks a lot cleaner in any case!

@wizeman
Copy link
Member Author

wizeman commented Jan 21, 2015

Done! It looks much better with your suggestions.
Let me know if you need anything else.

@wmertens
Copy link
Contributor

😍

wmertens added a commit that referenced this pull request Jan 22, 2015
nixos: When generating /etc/fstab, ZFS and NFS filesystems shouldn't be checked
@wmertens wmertens merged commit 8780caa into NixOS:master Jan 22, 2015
@wizeman wizeman deleted the u/zfs-dont-fsck branch March 17, 2015 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants