Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: Matomo 3.7.0 -> 3.8.1 #55540

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Security: Matomo 3.7.0 -> 3.8.1 #55540

merged 2 commits into from
Feb 14, 2019

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Feb 10, 2019 •
edited
Loading

Motivation for this change

3.8.0 was security-critical,
3.8.1 is a bugfix release for 3.8.0.

From my point of view, we should cherry-pick f0f9a118ca278a3fb66f88e10f618cd54886455a for 18.09 to fix the vulnerabilities only, while both commits should get into 19.03.
Both should neither contain breaking changes nor require no user intervention.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 10, 2019
@aanderse
Copy link
Member

@florianjacob looks like you forgot to actually bump the version number!

@florianjacob
Copy link
Contributor Author

@aanderse my bad >.< thanks! Now OfBorg should actually be able to build this thing…

@infinisil infinisil merged commit 3df95cf into NixOS:master Feb 14, 2019
@florianjacob florianjacob deleted the matomo branch February 14, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florianjacob @aanderse @infinisil @GrahamcOfBorg