Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brasero: fix libdvdcss usage #55740

Merged
merged 1 commit into from
Feb 14, 2019
Merged

brasero: fix libdvdcss usage #55740

merged 1 commit into from
Feb 14, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 14, 2019

turns out, prefixing LD_PRELOAD with the path to libdvdcss works just
fine. Verified by creating an iso image of a owned DVD.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
brasero: fix libdvdcss usage
ea44317 
turns out, prefixing LD_PRELOAD with the path to libdvdcss works just
fine.
@flokli flokli requested review from pSub and abbradar February 14, 2019 00:33
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 14, 2019
@pSub pSub merged commit 53a73b0 into NixOS:master Feb 14, 2019
@flokli flokli deleted the brasero-libdvdcss branch February 14, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flokli @pSub @GrahamcOfBorg