nixos/phpfpm: allow configuring php.ini files per-pool #55742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A follow up to #41440 which then allows you to specify different php.ini files per pool. Also fixes a bug where the php.ini which is supplied to a pool isn't necessarily a php.ini from the same version of php.
The nextcloud module sets some php.ini options which are applied to all pools. If accepted this PR would allow the nextcloud modules to set options in php.ini which don't impact other pools on the system, truly sandboxing it and allowing for much more reproducible systems.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)