Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/phpfpm: allow configuring php.ini files per-pool #55742

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

A follow up to #41440 which then allows you to specify different php.ini files per pool. Also fixes a bug where the php.ini which is supplied to a pool isn't necessarily a php.ini from the same version of php.
The nextcloud module sets some php.ini options which are applied to all pools. If accepted this PR would allow the nextcloud modules to set options in php.ini which don't impact other pools on the system, truly sandboxing it and allowing for much more reproducible systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Feb 14, 2019
@aanderse
Copy link
Member Author

@GrahamcOfBorg test nextcloud

@aanderse
Copy link
Member Author

@wmertens as this is a direct continuation of your PR any thoughts?

@jtojnar jtojnar merged commit 23eff45 into NixOS:master Feb 16, 2019
@jtojnar
Copy link
Member

jtojnar commented Feb 16, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants