Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update xhyve to tip of master #55856

Merged
merged 1 commit into from
Mar 18, 2019
Merged

update xhyve to tip of master #55856

merged 1 commit into from
Mar 18, 2019

Conversation

jsamsa
Copy link
Contributor

@jsamsa jsamsa commented Feb 15, 2019

Motivation for this change

run the latest xhyve

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [x ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Feb 15, 2019
@jsamsa
Copy link
Contributor Author

jsamsa commented Mar 4, 2019

Is there anything I can do to move this along?

LnL7
LnL7 approved these changes Mar 4, 2019
View reviewed changes
pkgs/applications/virtualization/xhyve/default.nix Outdated Show resolved Hide resolved
@LnL7
Copy link
Member

LnL7 commented Mar 18, 2019

@GrahamcOfBorg build xhyve

@GrahamcOfBorg GrahamcOfBorg requested a review from LnL7 March 18, 2019 22:54
@LnL7 LnL7 merged commit 8fce8a9 into NixOS:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb requested changes

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsamsa @LnL7 @srhb @GrahamcOfBorg