Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo: apply patch for CVE-2018-19876 #55894

Merged
merged 1 commit into from
Feb 17, 2019
Merged

cairo: apply patch for CVE-2018-19876 #55894

merged 1 commit into from
Feb 17, 2019

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

Security update; ref: #55384

This applies the patch from the following upstream merge request:
https://gitlab.freedesktop.org/cairo/cairo/merge_requests/5

This resulted in the following merge commit, which we fetch as a patch
and apply:
https://gitlab.freedesktop.org/cairo/cairo/commit/6edf572ebb27b00d3c371ba5ae267e39d27d5b6d

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ckauhaus

@srhb
Copy link
Contributor

srhb commented Feb 16, 2019

@GrahamcOfBorg eval

@andrew-d andrew-d changed the base branch from master to staging February 16, 2019 20:56
@andrew-d
cairo: apply patch for CVE-2018-19876
7c28cb2 
This applies the patch from the following upstream merge request:
    https://gitlab.freedesktop.org/cairo/cairo/merge_requests/5

This resulted in the following merge commit, which we fetch as a patch
and apply:
    https://gitlab.freedesktop.org/cairo/cairo/commit/6edf572ebb27b00d3c371ba5ae267e39d27d5b6d
@worldofpeace worldofpeace merged commit bad2db3 into NixOS:staging Feb 17, 2019
@worldofpeace
Copy link
Contributor

Thanks @andrew-d

@andrew-d andrew-d deleted the andrew/cairo-CVE-2018-19876 branch February 17, 2019 04:02
@andrew-d
Copy link
Contributor Author

@worldofpeace - Thanks for merging!

vcunat pushed a commit that referenced this pull request Feb 17, 2019
@worldofpeace @vcunat
Merge #55894: cairo: apply patch for CVE-2018-19876
21531d3 
(cherry picked from commit bad2db3)
Forward-picked from staging to staging-next;
it's a trivial patch and we now rebuild anyway due to unzip.
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrew-d @srhb @worldofpeace @vcunat @GrahamcOfBorg