Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: experimental 0.17.2 → 0.17.6 #56861

Merged
merged 2 commits into from
Mar 8, 2019
Merged

factorio: experimental 0.17.2 → 0.17.6 #56861

merged 2 commits into from
Mar 8, 2019

Conversation

artemist
Copy link
Member

@artemist artemist commented Mar 5, 2019

Motivation for this change

Factorio has been releasing a lot of bugfixes. This is the latest version (as of the time of writing)

Things done

Change the version and hashes

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 5, 2019
@artemist artemist changed the title factorio: experimental 0.17.2 → 0.17.5 factorio: experimental 0.17.2 → 0.17.6 Mar 6, 2019
@artemist
Copy link
Member Author

artemist commented Mar 6, 2019

Welp, Factorio 0.17.6 came out before this got merged, so I added it as another commit to this PR.

@infinisil infinisil merged commit 2dbd61d into NixOS:master Mar 8, 2019
@artemist artemist deleted the factorio-0.17.5 branch March 12, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemist @infinisil @GrahamcOfBorg