-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildGoPackage: update Go to version 1.12 #56927
buildGoPackage: update Go to version 1.12 #56927
Conversation
I'm running Building the following packages
|
3e24a85
to
89da25f
Compare
f1a31b4
to
871d1c3
Compare
0a794db
to
ee81ceb
Compare
@vcunat I need help merging this to staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a go person, but it seems good. Upstream claims a very high level of compatibility.
Going through staging should give a little time to fix (unlikely) "disasters", so I don't think we need to wait now for more contributors to notice.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)