Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turses: Fix #57092

Merged
merged 1 commit into from
Mar 9, 2019
Merged

turses: Fix #57092

merged 1 commit into from
Mar 9, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

Fixes turses build for #56826

Ref louipc/turses#4

I haven't sent a tweet, but the curses UI works no problem

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, gonna do the merge and backport dance.

@worldofpeace worldofpeace merged commit 2ef7d17 into NixOS:master Mar 9, 2019
@infinisil infinisil deleted the fix/turses branch March 9, 2019 01:28
@worldofpeace
Copy link
Contributor

backported in f0fb7c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infinisil @worldofpeace @GrahamcOfBorg