Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pantheon cleanup #57174

Merged
merged 2 commits into from
Mar 15, 2019
Merged

nixos/pantheon cleanup #57174

merged 2 commits into from
Mar 15, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Mar 9, 2019 •
edited
Loading

Motivation for this change

Basically use mkDefault more where we should, and add other programs that aren't a part of pantheon.apps to be filtered out with removePackagesByName.

Additionally remove some programs that don't need to be in systemPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/pantheon: cleanup systemPackages
c41a2d2 
We don't need gnome-bluetooth because its executables
path is already hardcoded into the contractor file, as that's
the only place it is needed.
Don't think we need gnome-power-manager either.

Also add programs like geary to removePackagesByName.
@worldofpeace
nixos/pantheon: more mkDefault
36d4dba
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 9, 2019
@infinisil
Copy link
Member

Are you trying out different DMs? :o

@worldofpeace
Copy link
Contributor Author

Are you trying out different DMs? :o

I pretty much flirt with all the cool one's 😄

@infinisil infinisil merged commit fb879ae into NixOS:master Mar 15, 2019
@worldofpeace worldofpeace deleted the pantheon/cleanup branch March 15, 2019 00:27
@worldofpeace
Copy link
Contributor Author

I'm backporting this so people can properly remove programs like geary and epiphany.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@worldofpeace @infinisil @GrahamcOfBorg