Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.priority: fix build #57807

Merged
merged 1 commit into from
Mar 19, 2019
Merged

python3Packages.priority: fix build #57807

merged 1 commit into from
Mar 19, 2019

Conversation

alyssais
Copy link
Member

The patch has been submitted upstream:
python-hyper/priority#135. It’s vendored here because the patch for master doesn’t apply to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from FRidh as a code owner March 17, 2019 16:14
@dotlambda
Copy link
Member

Isn't there a way to get rid of the timeout completely?

@dotlambda
Copy link
Member

I changed it to deadline=None.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 19, 2019
@dotlambda dotlambda merged commit bc3e7f8 into NixOS:master Mar 19, 2019
dotlambda pushed a commit that referenced this pull request Mar 19, 2019
@alyssais
python3Packages.priority: fix build (#57807)
d2e06ac 
(cherry picked from commit bc3e7f8)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alyssais @dotlambda @samueldr @GrahamcOfBorg