Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.cairocffi: make withXcffib work again #57855

Merged
merged 1 commit into from
Mar 19, 2019
Merged

python.pkgs.cairocffi: make withXcffib work again #57855

merged 1 commit into from
Mar 19, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 18, 2019 •
edited
Loading

Motivation for this change

#56839 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @kamilchm @Ma27

@dotlambda dotlambda requested a review from FRidh as a code owner March 18, 2019 13:00
kamilchm
kamilchm reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@kamilchm kamilchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thx.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 18, 2019
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 18, 2019
@dotlambda dotlambda merged commit 180c68d into NixOS:master Mar 19, 2019
dotlambda added a commit that referenced this pull request Mar 19, 2019
@dotlambda
python.pkgs.cairocffi: make withXcffib work again (#57855)
4649b76 
(cherry picked from commit 180c68d)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotlambda @kamilchm @samueldr @GrahamcOfBorg