Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

olive-editor: init at 0.0.1 #57867

Merged
merged 2 commits into from
May 10, 2019
Merged

olive-editor: init at 0.0.1 #57867

merged 2 commits into from
May 10, 2019

Conversation

balsoft
Copy link
Member

@balsoft balsoft commented Mar 18, 2019

Motivation for this change

This PR adds olive-editor, which is a professional open-source non-linear video editor written in Qt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 18, 2019
worldofpeace
worldofpeace suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've left some minor review comments.

You mostly need to work on adjusting the expression for Dawin support.
Shouldn't be too problematic for you to maintain, these type applications usually work fine there.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Show resolved Hide resolved
pkgs/applications/video/olive-editor/default.nix Outdated Show resolved Hide resolved
@balsoft
Copy link
Member Author

balsoft commented Mar 19, 2019

@worldofpeace I don't own Mac and never have. I have no experience in building packages for darwin, but I'll try.

@balsoft
Copy link
Member Author

balsoft commented Mar 19, 2019

@worldofpeace can you toggle a grahamc build?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Mar 19, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace can you toggle a grahamc build?

Yeah.

@GrahamcOfBorg build olive-editor

@balsoft
Copy link
Member Author

balsoft commented Mar 19, 2019

Thank you.

@worldofpeace
Copy link
Contributor

@worldofpeace I don't own Mac and never have. I have no experience in building packages for darwin, but I'll try.

Neither have I, if we need someone to test/review it I can find someone for you.

@balsoft
Copy link
Member Author

balsoft commented Mar 20, 2019

@worldofpeace Can you cc some trusted users who might review and build this on Darwin? I believe known users can't build it there cause it's not sandbox. (Also, I haven't found a list of trusted users)

@worldofpeace
Copy link
Contributor

@worldofpeace Can you cc some trusted users who might review and build this on Darwin? I believe known users can't build it there cause it's not sandbox. (Also, I haven't found a list of trusted users)

I am a trusted user.

It didn't build because of

Package ‘frei0r-plugins-1.6.1’ in /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/frei0r/default.nix:17 is not supported on ‘x86_64-apple-darwin’, refusing to evaluate.

I think we only need that for stdenv.isLinux

@c0bw3b
olive-editor: unstable-2019-03-18 -> 0.0.1
30b46d0 
Upstream tagged a first alpha release
+ frei0r is now available on Darwin
@c0bw3b
Copy link
Contributor

c0bw3b commented May 9, 2019 •
edited
Loading

I enabled Darwin build of frei0r in #60896 and upstream olive repo tagged a first alpha release.
Let's refresh this! :)
(I already tested locally -- it builds and runs)

@c0bw3b
Copy link
Contributor

c0bw3b commented May 9, 2019

Checking Darwin too
@GrahamcOfBorg build olive-editor

@c0bw3b c0bw3b changed the title olive-editor: init at 2019-03-18 olive-editor: init at 0.0.1 May 9, 2019
worldofpeace
worldofpeace approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on NixOS 👍

Darwin build timed out, hope it's fine.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

We'll know soon enough.
@balsoft congrats this is going live! :)

@c0bw3b c0bw3b merged commit 38c093e into NixOS:master May 10, 2019
@balsoft balsoft deleted the olive-editor-init branch May 11, 2019 04:45
tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
@tadeokondrak
olive-editor: init at 0.0.1 (NixOS#57867)
01d0653 
* olive-editor: init at unstable-2019-03-18

* olive-editor: unstable-2019-03-18 -> 0.0.1
Upstream tagged a first alpha release
+ frei0r is now available on Darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balsoft @worldofpeace @c0bw3b @GrahamcOfBorg