Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoreAudio to sox on macOS #57868

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Add CoreAudio to sox on macOS #57868

merged 1 commit into from
Mar 19, 2019

Conversation

Kaali
Copy link

@Kaali Kaali commented Mar 18, 2019

Otherwise no audio devices are available for recording and playback on
macOS.

Motivation for this change

Without CoreAudio sox cannot interface with macOS audio, which means no recording or playback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Otherwise no audio devices are available for recording and playback on
macOS.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Mar 18, 2019
@LnL7
Copy link
Member

LnL7 commented Mar 18, 2019

@GrahamcOfBorg build sox

@LnL7 LnL7 merged commit 373488e into NixOS:master Mar 19, 2019
@Kaali Kaali deleted the coreaudio-sox branch March 19, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants