Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.thinc: Fix build #58095

Merged
merged 1 commit into from
Apr 1, 2019
Merged

pythonPackages.thinc: Fix build #58095

merged 1 commit into from
Apr 1, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 22, 2019 •
edited
Loading

Motivation for this change

Fixes #58069

@shosti Please test thinc yourself to make sure it works with this fix

Pinging the maintainers @aborsu @sdll

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil requested a review from FRidh as a code owner March 22, 2019 00:35
@dotlambda dotlambda changed the title thinc: Fix build pythonPackages.thinc: Fix build Mar 22, 2019
@infinisil
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.thinc python3.pkgs.thinc

@dotlambda
Copy link
Member

ping @shosti @aborsu @sdll

dotlambda
dotlambda requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infinisil The commit message should be this PR's title.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 26, 2019
@infinisil infinisil merged commit d585794 into NixOS:master Apr 1, 2019
@infinisil infinisil deleted the fix/thinc branch April 1, 2019 03:44
@infinisil
Copy link
Member Author

Backported to 19.03 in a6b8541

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python37Packages.thinc fails to build on unstable
4 participants
@infinisil @dotlambda @samueldr @GrahamcOfBorg