Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base16-shell-preview: init at 0.3.0 #59547

Merged
merged 2 commits into from
Apr 19, 2019
Merged

base16-shell-preview: init at 0.3.0 #59547

merged 2 commits into from
Apr 19, 2019

Conversation

rencire
Copy link
Contributor

@rencire rencire commented Apr 15, 2019 •
edited
Loading

Motivation for this change

Want to add a new package for using base16-shell-preview tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rencire
Copy link
Contributor Author

rencire commented Apr 15, 2019

note: I am a beginner with nix. If there is any best practice I'm not following, or any suggestions, please let me know, thanks!

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 15, 2019
worldofpeace
worldofpeace previously requested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rencire

I've left a few minor comments, mostly standard stuff.

When you've correcting those you should split adding yourself to the maintainers list
into a separate commit. Like

maintainers: add rencire

pkgs/misc/base16-shell-preview/default.nix Outdated Show resolved Hide resolved
pkgs/misc/base16-shell-preview/default.nix Show resolved Hide resolved
pkgs/misc/base16-shell-preview/default.nix Outdated Show resolved Hide resolved
@grahamc
Copy link
Member

grahamc commented Apr 15, 2019

@GrahamcOfBorg eval

@worldofpeace
Copy link
Contributor

Looks great @rencire.

Can you squash the commits accordingly?
(add to maintainers list, add package)

@worldofpeace worldofpeace dismissed their stale review April 16, 2019 21:32

Resolved by author

@rencire
Copy link
Contributor Author

rencire commented Apr 19, 2019

@worldofpeace any update/feedback?

@worldofpeace
Copy link
Contributor

My apologies, sometimes with github I won't get a notification for when a push happens.

This looks good 👍

@worldofpeace worldofpeace merged commit a0ea9cc into NixOS:master Apr 19, 2019
@worldofpeace
Copy link
Contributor

Thank you for contributing @rencire ✨

@rencire rencire deleted the add-base-16-shell-preview branch April 20, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rencire @grahamc @worldofpeace @GrahamcOfBorg