Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup; Remove old patches #59754

Merged
merged 3 commits into from
May 18, 2019
Merged

Cleanup; Remove old patches #59754

merged 3 commits into from
May 18, 2019

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Apr 17, 2019 •
edited
Loading

Cleanup some patches and resources that got checked in.

Effects:

  • boost (cygwin patches)
  • pharo (resource directories)
  • xorg (dri_interface.h)
  • herqq (gcc6.patch)

Before:

$ du -sc pkgs
104084	pkgs

After:

$ du -sc pkgs
103696	pkgs
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
boost: remove old cygwin patches
a3ac12a 
Most of these are unused and the others only used in 1.59.
@matthewbauer
herqq: remove gcc6.patch
b714935 
not referenced in nix code
@matthewbauer
pharo: remove resource files
374e8f4 
These should be checked into upstream
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Apr 17, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 23, 2019

xorg (dri_interface.h)

Was that part left out on purpose after more consideration?
I can't tell if that file is still needed for Darwin builds or xorg

@matthewbauer matthewbauer merged commit 3d26f06 into NixOS:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewbauer @c0bw3b @NeQuissimus @GrahamcOfBorg