k3b misses cdrkit dependency

[solatis]

In the current unstable channel, k3b complains about a missing "cdrecord" executable. This executable can be found in the "cdrkit" package. After manually installing this package, k3b works fine.

This dependency should be added to the k3b package.

[ttuegel]

This is a known issue, and cannot be fixed with the current architecture of Nix. The cdrecord executable must be setuid-root, so it cannot reside in the store. Adding the dependency to the K3B package will not help.

As a workaround, we should add a NixOS option, such as programs.k3b.enable which installs K3B and cdrkit into the system environment.

[edolstra]

IIRC, cdrecord doesn't have to be setuid root. That's only necessary to get realtime scheduling. But that's probably not so important anymore.

[ttuegel]

In that case, I'll wrap k3b to suffix the path with cdrecord. If the user has the setuid version installed, that will be used instead.

[solatis]

I might be missing something, but wouldn't just adding cdrkit as a dependency solve the problem? If you look at this:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/cd-dvd/cdrkit/default.nix#L19

it makes wodin alias to cdrecord, which seems to work just fine in this case.

[ttuegel]

@solatis That will make cdrecord available at build-time, but not at runtime.

[ttuegel]

Fixed in 95829c8. I used propagatedUserEnvPkgs to propagate a dependency on cdrkit. Users who prefer the original cdrtools can override the cdrtools argument. This should not interfere with setuid root tools, which appear first on the path.