Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing dependency needed for testing flent #60360

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Added missing dependency needed for testing flent #60360

merged 1 commit into from
Apr 28, 2019

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Apr 28, 2019 •
edited
Loading

Fixed failing package by adding a missing dependency needed during testing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 28, 2019

@GrahamcOfBorg build flent

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 28, 2019

Hello @ahiaao
Thanks for the contribution to nixpkgs and for fixing this package. I'll merge this.

Note: for your next PRs take a look at the manual for contributions guidelines, notably the format of commit messages. 😉

@c0bw3b c0bw3b merged commit 7d558b2 into NixOS:master Apr 28, 2019
@ahiaao ahiaao deleted the flent-fix branch July 2, 2019 03:37
@ahiaao
Copy link
Contributor Author

ahiaao commented Jul 2, 2019

@NixOS/backports Can this get backported to release-19.03? #56826

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahiaao @c0bw3b @Janik-Haag