Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timetrap: use bundlerApp #60517

Merged
merged 1 commit into from
May 18, 2019
Merged

timetrap: use bundlerApp #60517

merged 1 commit into from
May 18, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Apr 30, 2019 •
edited
Loading

Motivation for this change

Exposed more executables than needed and was outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 30, 2019
alyssais
alyssais reviewed May 4, 2019
View reviewed changes
pkgs/applications/office/timetrap/default.nix
homepage = https://github.com/samg/timetrap;
license = licenses.mit;
maintainers = with maintainers; [ jerith666 manveru ];
platforms = platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this not to be platforms.all?

@globin globin merged commit d40443b into NixOS:master May 18, 2019
@manveru manveru deleted the timetrap-update branch December 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manveru @alyssais @globin