obfs4: init at 0.0.10, use in tor-browser-bundle's, tor service #60575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Alt PR title: OBFS4 Service Pack)
Introduction and Motivation for this change
This enables obfs4 for use in our tor service
and our tor-browser-bundle!
This is important because
(source)[https://2019.www.torproject.org/docs/bridges.html.en]:
Happily obfs4proxy supports scramblesuit too, as well as the other
obfs transports, which is particularly important for interacting
with peers that don't "yet" support obfs4.
In the tor and our bundle, this replaces the python-based obfsproxy
and makes it possible to replace obfs4proxy in tor-browser-bundle-bin
instead of patchelf'ing.
(we may wish to use the shipped binary anyway for fingerprinting
reasons, but since we patchelf it anyway I'm not sure if
there's good cause for using the version provided?)
For our built-from-source bundle this means
these transports are newly available for use.
Testing
I have not tested the tor module with this "yet",
help appreciated and especially any feedback from
folks using the module in a way this would impact :).
I've tested the browser bundles in a few bridge configurations
and am able to use obfs4 bridges and such.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)