trivial-builders: add writeShellScript and minor cleaning #61052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
alyssais
reviewed
May 6, 2019
Mic92
reviewed
May 7, 2019
| checkPhase = '' | ||
| ${stdenv.shell} -n $out | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Yes, Indeed, but I'm not sure what to do here. It's weird, that writeShellScriptBin exists but writeShellScript does not.
deliciouslytyped
force-pushed
the
patch-2
branch
3 times, most recently
from
db59142
to
61c44c9
Compare
Add writeShellScript Small whitespace additions Fix "Example:" docstring sections for some of the writeScript functions to use the correct function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add writeShellScript
Small whitespace additions
Fix "Example:" docstring sections for some of the writeScript functions to use the correct function
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)