Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.leveldb: init at 0.194 #61066

Merged
merged 1 commit into from
May 11, 2019
Merged

pythonPackages.leveldb: init at 0.194 #61066

merged 1 commit into from
May 11, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented May 7, 2019 •
edited
Loading

Motivation for this change

http://chriswarbo.net/blog/2018-05-02-fixing_leveldb.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from FRidh as a code owner May 7, 2019 01:26
@aanderse
Copy link
Member Author

aanderse commented May 7, 2019 •
edited
Loading

@GrahamcOfBorg build python2Packages.leveldb python3Packages.leveldb

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1-10 labels May 7, 2019
@aanderse
Copy link
Member Author

aanderse commented May 7, 2019

FYI @etu I used this to repair a corrupt gitea instance last night. Time to invest in a UPS -_-

@etu
Copy link
Contributor

etu commented May 7, 2019

@GrahamcOfBorg build python2Packages.leveldb python3Packages.leveldb

@etu
Copy link
Contributor

etu commented May 7, 2019

@aanderse Interesting, yeah, I have never used the sqlite backend. But yeah, that can happen with sqlite.

@aanderse
Copy link
Member Author

aanderse commented May 7, 2019

I'm taking a msql backend. It was the indexers directory which went corrupt after power loss.

@etu
Copy link
Contributor

etu commented May 7, 2019

@aanderse Oh, oh well. Not much the gitea module can do about it though. :/

@aanderse
Copy link
Member Author

aanderse commented May 7, 2019

Lesson learnt on my side... UPS will be ordered shortly, my bad.

Good to have this package in nixpkgs just in case though 😄

@aanderse aanderse merged commit 252420b into NixOS:master May 11, 2019
@aanderse aanderse deleted the pythonPackages.leveldb branch May 11, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanderse @etu