Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.celery: unpin moto #61305

Merged
merged 1 commit into from
May 18, 2019
Merged

pythonPackages.celery: unpin moto #61305

merged 1 commit into from
May 18, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 11, 2019

Requirements for testing pin at 1.3.7.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from FRidh as a code owner May 11, 2019 16:11
@eadwu eadwu mentioned this pull request May 11, 2019
Merged
10 tasks
FRidh
FRidh requested changes May 12, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pin at a patch release is nonsense. Remove the pin instead.

@eadwu eadwu force-pushed the pythonPackages.celery/fix-moto-dependency branch from a672fe2 to 58c998d Compare May 12, 2019 18:32
@eadwu eadwu changed the title pythonPackages.celery: use moto 1.3.7 pythonPackages.celery: unpin moto May 12, 2019
@globin globin merged commit 9cc417a into NixOS:master May 18, 2019
@eadwu eadwu deleted the pythonPackages.celery/fix-moto-dependency branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eadwu @FRidh @globin