aws-sdk-cpp: fix cross compilation #61519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix cross compilation of
nix
:nix build nixpkgs.pkgsCross.aarch64-multiplatform.nix
I think the problem was introduced in aws/aws-sdk-cpp@f024f1d.
Things done
Provided the expected result of a CMake
try_run
call. I'm really unsure about wether this is supposed to be0
or1
. The exit code of the test should be0
and the docs say that the variable should be set to the exit code, but it might be better if someone double checked wether this really translates to-DCURL_HAS_H2=0
.I did not run the build result, as I have no access to
aarch64
hardware atm.sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)