Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audacity: 2.3.1 -> 2.3.2 #61626

Merged
merged 1 commit into from
May 18, 2019
Merged

audacity: 2.3.1 -> 2.3.2 #61626

merged 1 commit into from
May 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2019

Motivation for this change

https://www.audacityteam.org/audacity-2-3-2-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from the-kenny May 17, 2019 10:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels May 17, 2019
tomberek
tomberek approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu.

@charles-dyfis-net
Copy link
Contributor

Hmm. They seem to have vendored a copy of LAME into the Audacity codebase between 2.3.1 and 2.3.2; it's not obvious whether the external dependency is used when provided, or if the internal one is always used (such that the external one could be dropped).

@FRidh
Copy link
Member

FRidh commented May 18, 2019

If I recall correctly they only vendor it on non-Linux platforms.

@globin
Copy link
Member

globin commented May 18, 2019

It's fine:

configure: Using SYSTEM libraries for LAME

@globin globin merged commit 9b61094 into NixOS:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtzWill @charles-dyfis-net @FRidh @globin @tomberek