Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk{2,3}-x11: build against pango with X11 support enabled #61942

Merged
merged 1 commit into from
May 23, 2019
Merged

gtk{2,3}-x11: build against pango with X11 support enabled #61942

merged 1 commit into from
May 23, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented May 23, 2019

Motivation for this change

On Darwin pango does not have X11 support enabled by default, but gtk{2,3}-x11 requires it. Force gtk{2,3}-x11 to be built against pango with X11 support enabled. Related to #61912.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member Author

smaret commented May 23, 2019

cc @matthewbauer

@smaret
Copy link
Member Author

smaret commented May 23, 2019

@GrahamcOfBorg build gtk2-x11 gtk3-x11

@smaret smaret mentioned this pull request May 23, 2019
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 23, 2019
@matthewbauer matthewbauer merged commit 2fc2013 into NixOS:master May 23, 2019
@smaret smaret deleted the gtk-x11-fix branch May 24, 2019 06:06
@smaret smaret mentioned this pull request May 24, 2019
Closed
@dhruvio dhruvio mentioned this pull request May 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaret @matthewbauer