Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.pyglet: hardcode library paths #62150

Merged
merged 2 commits into from
May 28, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented May 28, 2019

Motivation for this change

The new way to find libraries (basically a switch statement) isn't particularly pretty, but its simple and reliable. The old way failed to load libc, since libc.so is actually a linker script so we need to directly provide the path to libc.so.6. Other libraries were missing completely.

I tried to run the Cartpole example of rl-coach, which failed to render anything before and runs perfectly now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes failure to find certain libraries such as libc.
@timokau timokau requested a review from FRidh as a code owner May 28, 2019 11:48
@timokau
Copy link
Member Author

timokau commented May 28, 2019

@GrahamcOfBorg build python2.pkgs.pyglet python3.pkgs.pyglet

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 8.has: clean-up 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels May 28, 2019
@timokau timokau merged commit 444f22c into NixOS:master May 28, 2019
@timokau timokau deleted the pyglet-library-hardcode branch May 28, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant