Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dynd: Fix build #62166

Merged
merged 1 commit into from
May 28, 2019
Merged

python3Packages.dynd: Fix build #62166

merged 1 commit into from
May 28, 2019

Conversation

infinisil
Copy link
Member

Ping @teh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil requested a review from FRidh as a code owner May 28, 2019 18:47
@infinisil
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.dynd
@GrahamcOfBorg build python3.pkgs.dynd

@infinisil infinisil merged commit 875a015 into NixOS:master May 28, 2019
@infinisil infinisil deleted the fix/python-dynd branch May 28, 2019 20:25
@teh
Copy link
Contributor

teh commented Jun 1, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinisil @teh