Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krita: 4.1.8 -> 4.2.0 #62212

Closed
wants to merge 1 commit into from
Closed

krita: 4.1.8 -> 4.2.0 #62212

wants to merge 1 commit into from

Conversation

d3rped
Copy link
Contributor

@d3rped d3rped commented May 29, 2019

Motivation for this change

Krita 4.2.0 has been released.

Things done
  • Updated version number and checksum
  • Added new dependency quazip
Things to do
  • we may need to update qt5, are these changes already in nixpkgs?
  • update gmic_krita_qt, I should probably make a separate PR for that. (haven't used this so far, ?the current version seems to work with Krita 4.2.0 though?)
  • DONE: I'm not really familiar with CMake magic, I've set QUAZIP_INCLUDE_DIR and QUAZIP_LIBRARIES as environment variables but they are still not found during build... the relevant CMake files can be found here and here.
  • DONE: It now fails bceause there are ?missing functions? in quazip I'm an idiot - QUAZIP_LIBRARIES does not expect a directory.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar May 29, 2019 11:40
@d3rped d3rped changed the title [WIP] krita: 4.1.8 -> 4.2.0 krita: 4.1.8 -> 4.2.0 May 29, 2019
@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

@d3rped Tested, it works. I pushed with minor changes (quazip magic is no longer needed). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants