Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rfc3987: init at 1.3.8 #62312

Merged
merged 1 commit into from
Jun 5, 2019
Merged

pythonPackages.rfc3987: init at 1.3.8 #62312

merged 1 commit into from
Jun 5, 2019

Conversation

vanschelven
Copy link
Contributor

Motivation for this change

Add a useful python-package; this package is also a dependency of the jsonschema pythonpackage that will be added in a separate PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nfix-review wip" (there are no such packages)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vanschelven vanschelven requested a review from FRidh as a code owner May 31, 2019 14:17
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 31, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.rfc3987 python37Packages.rfc3987 python36Packages.rfc3987 python35Packages.rfc3987

@JohnAZoidberg
Copy link
Member

@GrahamcOfBorg build pythonPackages.rfc3987 python37Packages.rfc3987 python36Packages.rfc3987 python35Packages.rfc3987

@worldofpeace worldofpeace merged commit 75fba4a into NixOS:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanschelven @worldofpeace @JohnAZoidberg