weechatScripts.weechat-otr: init at 1.9.2

[oxzi]

Motivation for this change

This PR adds the otr.py script for WeeChat.

As discussed both in the NixOS Wiki and in potr's issue tracker before, potr does not work properly with the current version of pycryptodome and requires an older version of pycrpto. Therefore, the last release of pycrypto, with Debian's security patches applied, will be used.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[alexarice]

bit nitpicky but might look nicer with a line break somewhere round here

[oxzi]

I don't think there is a style guide for this. Scrolling through nixpkgs' manual brought up another in stdenv.mkDerivation in the same line. The let example in nix's manual does also continues on the same line.

[oxzi]

This PR was opened a month ago. What's the status?

[Lassulus]

Seems to have fallen under the radar. If you could post the usage here I will test this.

[oxzi]

@Lassulus: Thanks for picking up this PR.

You can test this WeeChat-Script as described in the WeeChat chapter of the nixpkgs manual. All you have to do is create an overlay for WeeChat with this package as a script.

[Lassulus]

alright, tested with the checkout PR and this beauty here:
nix-shell -p '(weechat.override { configure = {...}: { scripts = [ weechatScripts.weechat-otr ]; };})'
seems to work, since weechat shows this at startup:
registered script "otr", version 1.9.2 (Off-the-Record messaging for IRC)

can we build this with python3? python2 is gonna be EOL quite soon

[oxzi]

@Lassulus: Thanks a lot for testing the changes and your feedback.

can we build this with python3? python2 is gonna be EOL quite soon

Afaik, all WeeChat scripts are using the Python version of the weechat package. This packages inherits pythonPackages, if not overwritten. In the all-packages.nix file there is pythonPackages = python.pkgs and python = python2.

Thus I think that this is not in the scope of this PR. However, with WeeChat switching all scripts to Python 3 for the same deprecation reasons, one should do the same for the nixpkgs. On the other hand, changing python to python3 should do the work for WeeChat - and will likely break a thousand other packages.

[Lassulus]

alright, then I'm gonna merge this.

[Ma27]

tbh I haven't tried it yet, but I'd try to build weechat (and some of the scripts we support here) with python3 and if that works I'd simply pin python to python3 for weechat.

[koolfy]

Hello, I just wanted to drop by very quickly to publicly state that I am aware of the pycryptodome issue, and very ashamed of it. Work on that front has started out a while ago (proof: python-otr/pure-python-otr#68 ) and I'm the one responsible for the lack of progress :(

Thanks for the hack to make it work, I promise I'm trying to sort it out soon so you don't need to ship pycrypto just for potr anymore :/