Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcm2niix: 1.0.20170130 -> 1.0.20190410 #63479

Merged
merged 1 commit into from
Jun 19, 2019
Merged

dcm2niix: 1.0.20170130 -> 1.0.20190410 #63479

merged 1 commit into from
Jun 19, 2019

Conversation

lheckemann
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member Author

@GrahamcOfBorg build dcm2niix

Retrying the darwin build, since the cause of failure is unclear

@lheckemann
Copy link
Member Author

Merging as is for lack of evidence that it really doesn't work on Darwin.

@lheckemann lheckemann merged commit 32a992a into NixOS:master Jun 19, 2019
@lheckemann lheckemann deleted the dcm2niix branch June 19, 2019 10:08
lheckemann added a commit that referenced this pull request Jun 19, 2019
@lheckemann
dcm2niix: 1.0.20170130 -> 1.0.20190410 (#63479)
30a82bb 
(cherry picked from commit 2458209)
@lheckemann
Copy link
Member Author

A bit late, but cc @ashgillman fyi

@ashgillman
Copy link
Contributor

Looks good to me, I don't have mac to test Darwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lheckemann @ashgillman