Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idrisPackages.tparsec: 2018-12-21 -> 2019-06-18 #63623

Merged
merged 1 commit into from
Jun 22, 2019
Merged

idrisPackages.tparsec: 2018-12-21 -> 2019-06-18 #63623

merged 1 commit into from
Jun 22, 2019

Conversation

clayrat
Copy link
Contributor

@clayrat clayrat commented Jun 21, 2019

Motivation for this change

update idrisPackages.tparsec to latest rev

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clayrat clayrat requested a review from infinisil as a code owner June 21, 2019 15:58
@clayrat clayrat mentioned this pull request Jun 21, 2019
Closed
@infinisil infinisil merged commit 9e39f69 into NixOS:master Jun 22, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clayrat @infinisil @Janik-Haag