Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xonsh: 0.9.6 -> 0.9.8 #64715

Merged
merged 1 commit into from
Jul 28, 2019
Merged

xonsh: 0.9.6 -> 0.9.8 #64715

merged 1 commit into from
Jul 28, 2019

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jul 13, 2019 •
edited
Loading

Update to correct repo, since a group was created

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edmundmiller
xonsh: 0.9.6 -> 0.9.8
3335b49 
Update to correct repo, since a group was created
@ofborg ofborg bot requested a review from vrthra July 13, 2019 18:53
@mattmelling
Copy link
Contributor

Tested with nix-review, everything looks good 👍

@Ma27
Copy link
Member

Ma27 commented Jul 28, 2019

@GrahamcOfBorg build xonsh

Already tested locally, so it appears to be fine though :)

@Ma27 Ma27 merged commit c954e00 into NixOS:master Jul 28, 2019
@Ma27
Copy link
Member

Ma27 commented Jul 28, 2019

@emiller88 thanks!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundmiller @mattmelling @Ma27 @Janik-Haag