Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nethack: wrapQtApp only in qtMode #65528

Merged
merged 1 commit into from
Jul 29, 2019
Merged

nethack: wrapQtApp only in qtMode #65528

merged 1 commit into from
Jul 29, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 28, 2019 •
edited
Loading

Motivation for this change

Regression introduced in #54525, tracked in #65399.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
nethack: wrapQtApp only in qtMode
6f9fa06 
Regression introduced in NixOS#54525, tracked in NixOS#65399.
@ofborg ofborg bot requested a review from abbradar July 28, 2019 21:39
worldofpeace
worldofpeace approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nethack-qt works for me 👍

@worldofpeace worldofpeace merged commit 59f3cfa into NixOS:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmahut @worldofpeace