Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udis86: init at 1.7.2 #66099

Merged
merged 1 commit into from
Aug 31, 2019
Merged

udis86: init at 1.7.2 #66099

merged 1 commit into from
Aug 31, 2019

Conversation

timor
Copy link
Member

@timor timor commented Aug 5, 2019

Motivation for this change

This is a dependency for factor-lang.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 5, 2019
jonringer
jonringer reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
besides a few suggestions, LGTM
binary seems to work fine :)

pkgs/development/tools/udis86/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/udis86/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/udis86/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/udis86/default.nix Show resolved Hide resolved
@timor
Copy link
Member Author

timor commented Aug 5, 2019

Applied the suggestions. Thanks.

aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just 2 small things please.

pkgs/development/tools/udis86/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/udis86/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Aug 31, 2019
@aanderse
Copy link
Member

@GrahamcOfBorg build udis86

aanderse
aanderse approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging based on review and testing provided by @jonringer. Thanks @timor! 🎉

@aanderse aanderse merged commit 945f47a into NixOS:master Aug 31, 2019
@timor timor deleted the udis86 branch August 31, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timor @aanderse @jonringer