Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musescore: use qt5's mkDerivation #66533

Merged
merged 1 commit into from Aug 13, 2019
Merged

musescore: use qt5's mkDerivation #66533

merged 1 commit into from Aug 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2019

Motivation for this change

See #65399
Fixes Solo and Mute icons in Mixer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 12, 2019
worldofpeace
worldofpeace approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes for me. Verified that the binary was wrapped.

@worldofpeace worldofpeace merged commit 233b0af into NixOS:master Aug 13, 2019
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-linux: 1-10 labels Aug 13, 2019
@ghost
Copy link
Author

ghost commented Aug 13, 2019

@worldofpeace Thank you!

@ghost ghost deleted the musescore branch August 13, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@worldofpeace