Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efivar: patch build system for reproducibility #66548

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Aug 13, 2019

Motivation for this change

Make efivar build reproducible. The patch has been submitted upstream.

nix-build --check -A efivar now passes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @grahamc (r13y)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 13, 2019
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build efivar

@mmahut mmahut merged commit 2871348 into NixOS:master Aug 13, 2019
patches = [
(fetchurl {
name = "r13y.patch";
url = "https://patch-diff.githubusercontent.com/raw/rhboot/efivar/pull/133.patch";
Copy link
Member

@grahamc grahamc Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Nice to get r13y another step forward :D

Two notes (for both @delroth and @mmahut):

  1. generally we should use fetchpatch over fetchurl for patches, as it makes the patches a bit more stable
  1. these pull request .patch URLs are quite unstable. As the PR branch changes, or the branch it is merged in to changes, this patch will change contents and the hash will become invalid. In this case fetching the commit's patch directly (https://github.com/delroth/efivar/commit/b81e2f7d72d79b941f71962819606b802e6e835c.patch) would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants