Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irssi: build bundled OTR plug-in and remove "irssi-otr" package #66821

Merged
merged 1 commit into from
Aug 19, 2019
Merged

irssi: build bundled OTR plug-in and remove "irssi-otr" package #66821

merged 1 commit into from
Aug 19, 2019

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Aug 18, 2019

Motivation for this change

Make OTR available in Irssi with a lesser chance of compability problems.

https://irssi.org/2019/02/12/irssi-1.2.0-otr-migration-path/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@ofborg ofborg bot requested a review from lovek323 August 18, 2019 10:54
@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build irssi

mmahut
mmahut approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit 1412af4 into NixOS:master Aug 19, 2019
@ehmry ehmry deleted the irssi branch August 20, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmry @mmahut