Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.python-unshare: init at 0.2 #66893

Merged
merged 2 commits into from
Aug 19, 2019
Merged

python.pkgs.python-unshare: init at 0.2 #66893

merged 2 commits into from
Aug 19, 2019

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Aug 19, 2019 •
edited
Loading

Motivation for this change

Add a package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'll merge it when tests pass.

@abbradar abbradar requested a review from FRidh as a code owner August 19, 2019 09:23
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 19, 2019
@abbradar @jonringer
Update pkgs/development/python-modules/python-unshare/default.nix
1abd478 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@abbradar abbradar merged commit a92f719 into NixOS:master Aug 19, 2019
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-linux: 1-10 labels Aug 19, 2019
PsyanticY pushed a commit to PsyanticY/nixpkgs that referenced this pull request Aug 19, 2019
@abbradar @jonringer @PsyanticY
python.pkgs.python-unshare: init at 0.2 (NixOS#66893)
c3ba3c6 
* python.pkgs.python-unshare: init at 0.2

* Update pkgs/development/python-modules/python-unshare/default.nix

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbradar @jonringer