Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notmuch-bower: 0.10 -> 0.11 #66971

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 19, 2019

Motivation for this change

https://github.com/wangp/bower/blob/0.11/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @erictapen

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 19, 2019
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

When trying to run bower it doesn't find notmuch:

# ./bower 
/bin/sh: line 0: exec: notmuch: not found
Errors in configuration file:
process returned with exit code 127
could not derive default from_address from .notmuch-config

@erictapen
Copy link
Member

@mmahut It doesn't make sense to use notmuch-bower without notmuch so I guess that is not a problem.

For me this works, thanks for the bump, @dtzWill!

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@erictapen should that be taken as a dependency then?

@erictapen
Copy link
Member

@mmahut From the notmuch-bower Readme:

Bower is designed such that it can be run on the local machine but call out to notmuch on a remote machine (that holds your mail) via ssh. The advantage is that you can start helper programs on the local machine (e.g. a web browser or image viewer), and add or save attachments on the local filesystem, even if your mail archive is stored on a different machine.

So I guess that usecase doesn't need a locally installed notmuch. In case you still think notmuch should be installed could you open another issue for this? The behaviour you describe has been the case for all former versions of notmuch-bower.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

@erictapen I see, thank you for explanation!

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 20bddfe into NixOS:master Aug 22, 2019
@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

@dtzWill thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants