Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wsjtx: Fix qt errors #67041

Merged
merged 1 commit into from
Aug 20, 2019
Merged

wsjtx: Fix qt errors #67041

merged 1 commit into from
Aug 20, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 20, 2019

Motivation for this change

Also do minor fixes of the derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lasandell @adisbladis

@etu
wsjtx: Fix qt errors
b6014da 
Also do minor fixes of the derivation.
@etu etu requested a review from adisbladis August 20, 2019 08:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Aug 20, 2019
@adisbladis adisbladis merged commit 1f80bae into NixOS:master Aug 20, 2019
@etu etu deleted the wsjtx-fix-run branch August 20, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etu @adisbladis