Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic-colors: 0.2.2.1 -> 0.2.2.2 #67169

Merged
merged 1 commit into from
Aug 26, 2019
Merged

dynamic-colors: 0.2.2.1 -> 0.2.2.2 #67169

merged 1 commit into from
Aug 26, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Minor update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 21, 2019
aaronjanse
aaronjanse suggested changes Aug 21, 2019
View reviewed changes
pkgs/tools/misc/dynamic-colors/default.nix
--replace /usr/share/dynamic-colors $out/share/dynamic-colors
'';

meta = with stdenv.lib; {
description = "Change terminal colors on the fly";
homepage = https://github.com/peterhoeg/dynamic-colors;
homepage = "https://github.com/peterhoeg/dynamic-colors";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for putting this URL in quotes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NixOS/rfcs#45

The main issue AFAICT is that non-Nix-aware tools stumble on the semicolon, e.g. when you right-click and "open link" in a terminal emulator.

@peterhoeg
Copy link
Member Author

peterhoeg commented Aug 22, 2019 via email

@peterhoeg peterhoeg merged commit 6d43bc3 into NixOS:master Aug 26, 2019
@peterhoeg peterhoeg deleted the u/dyncol branch August 26, 2019 06:33
@peterhoeg peterhoeg restored the u/dyncol branch August 26, 2019 09:58
@peterhoeg peterhoeg deleted the u/dyncol branch August 26, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gloaming gloaming gloaming left review comments

@aaronjanse aaronjanse aaronjanse requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterhoeg @gloaming @aaronjanse