php: disable mhash #67212
Merged
php: disable mhash #67212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://www.php.net/manual/en/intro.mhash.php, mhash extension is obsolete, so disabling it here. (Also it doesn't cross-compile) **Warning**: This could be a breaking change for some packages that are very old and rely on this extension, maintainer discretion is advised.
|
@GrahamcOfBorg build php72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Per https://www.php.net/manual/en/intro.mhash.php, mhash extension is obsolete, so disabling it here. (Also it doesn't cross-compile)
Warning: This could be a breaking change for some packages that are very old and could rely on this extension, maintainer discretion is advised.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"(except packages under unfree license that prevents Nix from automatically downloading package distributions)./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @etu @globin
also cc @aanderse (requested in IRC when discussing this change)