Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fhs-chrootenv's environment and workaround Steam's sound issues #6730

Merged
merged 5 commits into from
Mar 9, 2015

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Mar 9, 2015

This adds locale support in FHS chrootenv, reworks environment, unifies and refactors /etc and finally workarounds Steam and its games' PulseAudio sound issues.

One controversial thing this uses is storing absolute symlinks like "/host-etc/passwd" in Nix store; this allows to greatly unify code between fhs-chrootenv and fhs-userenv.

Also this makes FHS chroot less NixOS-specific; if someone has used it in just Nix, they should have less issues now.

cc @jagajaga

@abbradar abbradar changed the title Cleanup fhs-chrootenv's environment and workarounds Steam's sound issues Cleanup fhs-chrootenv's environment and workaround Steam's sound issues Mar 9, 2015
@jagajaga
Copy link
Member

jagajaga commented Mar 9, 2015

Seems pretty nice.
Have you built it locally? There is a travis error, but it's not connected with subject.

@jagajaga jagajaga added the 0.kind: enhancement Add something new label Mar 9, 2015
@abbradar
Copy link
Member Author

abbradar commented Mar 9, 2015

Yes, it fixed my sound issues at least at expense of ld.so errors spam (it's a shame we don't have LD_PRELOAD_32/LD_PRELOAD_64).

jagajaga added a commit that referenced this pull request Mar 9, 2015
Cleanup fhs-chrootenv's environment and workaround Steam's sound issues
@jagajaga jagajaga merged commit 84ab385 into NixOS:master Mar 9, 2015
@abbradar abbradar deleted the chrootenv-sound branch March 9, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants