Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: 3.47.0 -> 3.47.1 #67937

Merged
merged 1 commit into from
Sep 5, 2019
Merged

calibre: 3.47.0 -> 3.47.1 #67937

merged 1 commit into from
Sep 5, 2019

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Updating to latest version.

Also rename .desktop files to match app IDs (fixes missing app icons on Wayland).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

Also rename .desktop files to match app IDs (fixes missing app icons on
Wayland).
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 2, 2019
Copy link
Member

@spacekookie spacekookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the calibre-edit-ebook rename is entirely neccessary but otherwise this update looks good

@lightbulbjim
Copy link
Contributor Author

lightbulbjim commented Sep 2, 2019

Not sure the calibre-edit-ebook rename is entirely neccessary but otherwise this update looks good

calibre-edit-book is the app ID of the ebook editor. Before the change the app icon wasn't shown under Wayland (see https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon).

Interestingly the upstream filename is calibre-ebook-edit.desktop, which should also be problematic (I haven't tested it to confirm). It wouldn't surprise me if it's just never been tested under Wayland - lots of apps have similar misconfigurations.

@ryantm ryantm merged commit 1fad270 into NixOS:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants