Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixfmt: init at 0.3.0 from haskellPackages #68013

Merged
merged 1 commit into from
Sep 4, 2019
Merged

nixfmt: init at 0.3.0 from haskellPackages #68013

merged 1 commit into from
Sep 4, 2019

Conversation

yorickvP
Copy link
Contributor

@yorickvP yorickvP commented Sep 3, 2019

Motivation for this change

This adds a 'justStaticExecutables' package for nixfmt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@yorickvP
Copy link
Contributor Author

yorickvP commented Sep 3, 2019

@GrahamcOfBorg build nixfmt

@kirelagin
Copy link
Member

Fixes NixOS/nixfmt#36

@kirelagin kirelagin mentioned this pull request Sep 3, 2019
Closed
@jagajaga jagajaga merged commit 3dd112c into NixOS:master Sep 4, 2019
@kirelagin kirelagin deleted the nixfmt branch September 4, 2019 11:09
@matthew-piziak
Copy link
Contributor

And now we wait: https://howoldis.herokuapp.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yorickvP @kirelagin @matthew-piziak @jagajaga