Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedtest-cli: 2.1.1 -> 2.1.2 #68066

Merged
merged 1 commit into from
Sep 4, 2019
Merged

speedtest-cli: 2.1.1 -> 2.1.2 #68066

merged 1 commit into from
Sep 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dtzWill dtzWill requested a review from FRidh as a code owner September 4, 2019 00:48
jonringer
jonringer approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work
leaf package

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68066
2 package were build:
python27Packages.speedtest-cli speedtest-cli

@aanderse
Copy link
Member

aanderse commented Sep 4, 2019

Merging based on good word of @jonringer.

@aanderse aanderse merged commit 8b9001d into NixOS:master Sep 4, 2019
@makefu
Copy link
Contributor

makefu commented Sep 4, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@ndowens ndowens Awaiting requested review from ndowens

@domenkozar domenkozar Awaiting requested review from domenkozar

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzWill @aanderse @makefu @jonringer